feat: add OpenExplorerUi restricted action (ExplorerUi, OpenExplorerUiResult)#451
Open
popuz wants to merge 1 commit into
Open
feat: add OpenExplorerUi restricted action (ExplorerUi, OpenExplorerUiResult)#451popuz wants to merge 1 commit into
popuz wants to merge 1 commit into
Conversation
…iResult) Same change as #446 (experimental), re-applied onto main for RGL review per the protocol contribution flow: main is the review target, the experimental PR stays for Unity testing and closes after the main sync. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Test this pull request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an
OpenExplorerUiRPC to the existingRestrictedActionsServiceso SDK7 scenes can open native explorer UI panels (Map, Settings, Backpack, Camera Reel, Communities, Places, Events) through~system/RestrictedActions.ExplorerUi— 7 fullscreen sections;EU_SETTINGSholds the zero value so an unsetuifield defaults to the least-intrusive panel.OpenExplorerUiResult— the open verdict:UNSPECIFIED,OPENED,WAS_ALREADY_OPEN,REJECTED_NOT_CURRENT_SCENE,REJECTED_FEATURE_DISABLED,REJECTED_NO_USER_GESTURE.OpenExplorerUiRequest { ExplorerUi ui }/OpenExplorerUiResponse { OpenExplorerUiResult open_result }(dedicated response, not the sharedSuccessResponse; the request documents aoneofextension point for future per-panel params).rpc OpenExplorerUi(OpenExplorerUiRequest) returns (OpenExplorerUiResponse)onRestrictedActionsService.Additive and non-breaking. Only
proto/decentraland/kernel/apis/restricted_actions.protochanged.Context
Iteration 1 of the Scene-triggered Explorer UI feature. This is the review PR into
mainper the protocol contribution flow; #446 carries the exact same change onexperimentalfor Unity testing and will be closed once the main→experimental sync lands.Testing
Consumed downstream by js-sdk-toolchain (decentraland/js-sdk-toolchain#1485,
~system/RestrictedActionscodegen) and unity-explorer (decentraland/unity-explorer#9472, C# implementation with QA test scene) on matchingfeat/scene-triggered-explorer-uibranches.🤖 Generated with Claude Code