feat: Pulse scene listeners#450
Open
kuruk-mm wants to merge 1 commit into
Open
Conversation
* feat: add SceneListenerHandshakeRequest to ClientMessage Scene-listener connect message: signed-fetch auth chain, realm, and an immutable parcel-index AoI. New ClientMessage oneof case (= 8). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat: scene-listener AoI as parcel rects Replace SceneListenerHandshakeRequest.parcel_indices with inclusive parcel-coordinate rects (sint32) so big scenes announce their AoI in a few bytes. The sum of rect areas is capped server-side. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Test this pull request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #449 so the base Pulse protocol can land in
mainwithout the scene-listeners surface. This PR re-targets the scene listeners work (originally #437) ontofeat/pulse:SceneListenerHandshakeRequest— scene-listener connect message asClientMessageoneof case8: same signed-fetchauth_chainshape asHandshakeRequest,realmpartition, and an immutable area of interest fixed for the connection lifetime. A listener is never a subject, so there is no initial state.ParcelRect— inclusive parcel-coordinate rects (sint32) so large scenes announce their AoI in a few bytes; the sum of rect areas is capped server-side (SceneListener:MaxParcels).Test plan
protoccompilespulse_client.protocleanly with the new messagesSceneListener:MaxParcelsClientMessagecases (1–7) are unchanged