chore: deprecate in favor of decentraland/core-libs - #355
Conversation
The package source now lives in the core-libs monorepo under libs/content-validator. This repository will no longer receive new releases; consumers should keep depending on @dcl/content-validator on npm — new versions will continue to publish from core-libs.
Test this pull request
|
|
coverage: 83.88%. remained the same — chore/deprecate-in-favor-of-core-libs into main |
decentraland-bot
left a comment
decentraland-bot
left a comment
There was a problem hiding this comment.
Review: chore: deprecate in favor of decentraland/core-libs
Clean deprecation notice. The README replacement is well-written: it clearly states where the package moved, confirms the npm package name is unchanged, provides migration instructions for all three package managers, and links to the new source location for issues and PRs.
Findings
No P0 or P1 issues.
[P2] Minor: The README still carries the old repo's Decentraland logo image tag at the top (<img src="https://ui.decentraland.org/decentraland_256x256.png">). This is fine to keep for branding, but could also be removed since the repo is deprecated. Not blocking.
Summary
| Level | Count |
|---|---|
| P0 — Blocker | 0 |
| P1 — Major | 0 |
| P2 — Minor | 1 |
CI Status: ✅ All checks passing
Verdict: Approved — no blockers. Ready to merge once the companion PR (core-libs#17) lands and the first monorepo version publishes successfully.
Reviewed by Jarvis 🤖 · Requested by Lautaro Petaccio via Slack
3 participants
Summary
Marks this repository as deprecated.
@dcl/content-validatorhas moved intodecentraland/core-libsunderlibs/content-validator, where it can share tooling and consume@dcl/hashing/@dcl/urn-resolvervia workspace references.The npm package name is unchanged. No action is required for consumers — new versions will continue to publish to
@dcl/content-validatoron npm, just from the monorepo.Companion PR
Migration into the monorepo: decentraland/core-libs#17
Test plan
@dcl/content-validatorpackage.