fix: update ADR-316 spring bones implementation#319
Merged
Conversation
Deploying adr with
|
| Latest commit: |
dc236aa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50744705.adr-cvq.pages.dev |
| Branch Preview URL: | https://feat-spring-bones-metadata.adr-cvq.pages.dev |
Contributor
|
Added missing max spring bones validation rule (12 per GLB representation) to the Deploy-time Validation section. |
…validation" This reverts commit 77d3c3a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request updates ADR-316 to change where and how spring bone physics parameters are stored for Decentraland wearables. Instead of embedding parameters in the
.glbmodel file via a glTF vendor extension, all spring bone configuration now lives in the wearable item's metadata (wearable.data.springBones), keyed by the GLB content hash. The.glbfile only encodes bone names and hierarchy. This approach reduces asset churn, simplifies parameter editing, and streamlines validation. The document is thoroughly revised to reflect this new standard, including vocabulary, examples, schema, and validation rules.Key changes:
Spring bone parameter storage and identification:
wearable.data.springBones, keyed by GLB content hash, rather than as a glTF vendor extension inside the.glbfile. The.glbonly contains bone names and hierarchy.springbone(case-insensitive) and anisRoot: trueentry for that node in the metadata, not by a glTF extension. [1] [2]Specification and schema updates:
springBones, and explains the rationale for not using in-GLB storage methods.stiffness,gravityPower,gravityDir,drag,isRoot, andcenter.Explorer and Builder behavior:
.glb, and reconstruct chains by matching bone names and hierarchy.Validation:
springbone.