chore: update explorer ADRs#317
Merged
Merged
Conversation
Deploying adr with
|
| Latest commit: |
cb4565a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://162904d9.adr-cvq.pages.dev |
| Branch Preview URL: | https://fix-update-depracated-adrs.adr-cvq.pages.dev |
decentraland-bot
left a comment
decentraland-bot
left a comment
Contributor
There was a problem hiding this comment.
Review Summary
Nice housekeeping work! This PR does two things well:
- Deprecates/withdraws 19 old ADRs related to the legacy unity-renderer and kernel, each with a proper status change in frontmatter and a clear deprecation/withdrawal reason section at the bottom.
- Adds 6 new ADRs (291–296) documenting the current unity-explorer architecture: ECS plugin system, avatar rendering pipeline, emotes system, runtime architecture, realm modifiers, and unreleased wearables/emotes preview.
Findings
Minor issues
-
ADR-20 and ADR-65: Both files end without a trailing newline (
No newline at end of filein the diff). This is cosmetic but worth fixing for consistency with the rest of the ADR files. -
ADR-296 date mismatch: ADR-296 has
date: 2026-03-26while all other new ADRs usedate: 2026-03-23. If they were all authored on the same date, this should be aligned.
Observations (no action needed)
- The deprecation reasons are clear and consistently reference the replacement ADRs where applicable — great for traceability.
- The new ADRs are well-structured with comparison tables against the old ADRs they replace, which makes the migration context easy to follow.
- All new ADRs are in
Draftstatus, which is appropriate. - Cross-references between deprecated and new ADRs are bidirectional (e.g., ADR-56 → ADR-291 and ADR-291 → ADR-56). 👍
CI Status
- ✅
build— passed - ⏳
Cloudflare Pages— pending (deploy preview)
Overall this looks good to go. Just the minor trailing-newline and date consistency nits above.
Requested by Agnieszka Besz via Slack
pentreathm
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.