feat: ADR 292 customize nametag color#315
Open
Maurizio-dcl wants to merge 5 commits into
Open
Conversation
Maurizio-dcl
changed the title
Maurizio-dcl
changed the title
Deploying adr with
|
| Latest commit: |
8443333
|
| Status: | 🚫 Build failed. |
Comment on lines
+102
to
+105
| "r": 0.282352954, | ||
| "g": 0.8627451, | ||
| "b": 0.458823532, | ||
| "a": 1 |
Contributor
There was a problem hiding this comment.
Why is it important to allow users to adjust the opacity of their names? The original issue states:
It will not be possible to change the saturation or brightness, so only the HUE can be changed, to ensure that it remains legible against the black background (nametag background).
Shouldn't we apply the same principle to the alpha channel of RGBA?
There was a problem hiding this comment.
We are ok with using Color3 without an alpha channel
Author
There was a problem hiding this comment.
Updated nameColor member type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR to allow user name color customization