feat: ADR-289 Explorer client scenes signed fetch - #308
Merged
Conversation
Deploying adr with
|
| Latest commit: |
7edb9e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://062c6f34.adr-cvq.pages.dev |
| Branch Preview URL: | https://feat-explorer-client-scenes.adr-cvq.pages.dev |
pentreathm
reviewed
Nov 7, 2025
pentreathm
reviewed
Nov 7, 2025
pentreathm
approved these changes
Nov 7, 2025
LautaroPetaccio
changed the title
LautaroPetaccio
changed the title
Member
|
Can you rename it to ADR-289? We have the ADR-288 PR open Anyway if it is merged, we can change to ADR-289 ours |
LautaroPetaccio
changed the title
gonpombo8
approved these changes
Nov 11, 2025
aleortega
approved these changes
Nov 14, 2025
aleortega
left a comment
aleortega
left a comment
Contributor
There was a problem hiding this comment.
LGMT!
My only doubt is if we should mention something about sandboxed environment the scenes run on and also the SDK
Co-authored-by: Alejo Thomas Ortega <alejothomasortega@gmail.com> Signed-off-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR describes how the Explorer Client performs fetches (signed fetches to be more specific) when performing a fetch in a scene.
Closes https://github.com/decentraland/core-team/issues/123