Repository navigation
FEAT: estimate card and swap timeline in the preflight dialog - #206
Merged
Merged
Conversation
decay71
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimate lane, group 3 and 4 of the plan (#193). UI only: the estimate and timeline data already ship with the plans since #199, and nothing in the backend or the model changes.
What it adds
estimatemessage to the browser worker for the plan being edited. The card dims while it runs and keeps the analysed numbers if the worker fails. The server path has no recompute, since the endpoint was removed in FEAT: preflight estimate data (timeline, estimate per plan, re-estimate) #199, so an edit there leaves the analysed numbers in place.≈ time (+delta, estimated). Classic lists every plan at once, so a single card would not say which plan it describes.ui.preflight.est_*keys and two swap kinds (cross_ace_bg,head_change) in en, de and zh. The de and zh strings are my own translation and need a native check. The card reusesfmtDurationandswapKindLabelfrom the History tab.Not in this PR
ACE_BG_WAITarrival hold.Testing
node --checkonapp.jsis clean.pytest tests/unit: 522 passed, 11 failed. The same 11 fail on main without this change (test_bg_pick_notice.py,test_web_golden.py). They come from stale local test files and golden data, not from this PR.