Repository navigation
FIX: Control tab target boxes and enclosure fans during a print - #194
Merged
Merged
Conversation
Collaborator
Author
|
This PR covers your first two points on PR #188: the nozzle/bed target boxes now show the current target, and the enclosure fan sliders work during a print, with a short hint while a mode runs. The |
decay71
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the Control tab (#188), from the feedback after testing on a U1.
Target boxes (nozzle, bed). The boxes were cleared after each send, so a spinner arrow always started from an empty field and sent 1 °C. They now show the current target, so an arrow steps from the real value. While you are in a box your typed value wins over the readback, and leaving it shows the target again. An empty box still sends nothing.
Enclosure fans during a print. "Fans off" worked mid-print but the sliders were blocked, so the fans could be stopped and not started again. Stock accepts
SET_PURIFIERat any time, soexhaustandinnerare now allowed during a print or pause, whatever the mode (an enclosure still has to be attached). The sliders are enabled, and while a mode runs a short hint says it may override the exhaust value. Outside a print nothing changes: the sliders stay disabled while a mode runs.Tests: both fans are accepted during a print and a pause in modes 0, 1 and 3, a missing enclosure is still refused, and the refused-while-printing cases are removed.
tests/unitpasses. The UI changes were checked in mock mode.test_restart.py(root runner) is not part of this PR.