Skip to content

Move clone and delete - #84

Merged
deanblackborough merged 5 commits into
mainfrom
move-clone-and-delete
Jun 25, 2026
Merged

Move clone and delete#84
deanblackborough merged 5 commits into
mainfrom
move-clone-and-delete

Conversation

@deanblackborough

@deanblackborough deanblackborough commented Jun 25, 2026

Copy link
Copy Markdown
Owner
  • Move clone and delete into the tool palette
  • Updated the controls
  • Renamed the tool sections
  • Removed tasks from notes

Summary by CodeRabbit

  • New Features

    • Added selection actions for cloning and deleting objects directly in the editor.
    • Updated the tool palette to show a dedicated Selected section when actions are available.
    • Improved shortcut/help text to reflect cloning, selection tools, and artillery controls.
  • Bug Fixes

    • Unified delete and duplicate/clone shortcuts with the new selection action handling.
    • Made action availability depend on the current selection, improving when controls are shown.

@deanblackborough
deanblackborough merged commit b7b9434 into main Jun 25, 2026
1 check passed
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8e22a33f-795d-4c58-92b2-c9e76c0ee20b

📥 Commits

Reviewing files that changed from the base of the PR and between c626b58 and 52c95be.

📒 Files selected for processing (9)
  • CMakeLists.txt
  • NOTES.md
  • src/prune/editor/editor_actions.cpp
  • src/prune/editor/editor_actions.hpp
  • src/prune/scene/scene_interaction.cpp
  • src/prune/tooling/controls.cpp
  • src/prune/tooling/inspector.cpp
  • src/prune/tooling/inspector.hpp
  • src/prune/tooling/ui.cpp

📝 Walkthrough

Walkthrough

This PR adds a shared editor action API for selection availability, cloning, and deleting. It moves the Delete/Backspace and Ctrl+D handling in scene interaction to those shared helpers, removes the inline Clone/Delete buttons from the inspector, and updates the tool palette to show selection actions when available. The controls text and roadmap note are updated to match the new action flow.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

  • deanblackborough/Prune#20: Both PRs touch the selected-object editor UI and clone offset handling in the inspector path.
  • deanblackborough/Prune#73: The new clone/delete helpers record editor commands and depend on the command flow added there.
  • deanblackborough/Prune#78: The delete helper’s multi-delete handling builds on the multi-selection and multi-delete infrastructure from that PR.

Suggested labels

enhancement

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-clone-and-delete

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Jun 25, 2026
@deanblackborough
deanblackborough deleted the move-clone-and-delete branch July 1, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant