Update notes and fix scene lifestyle issues

[deanblackborough]

Summary by CodeRabbit

• Bug Fixes
  • Corrected scene initialisation lifecycle to prevent loaded content from being overwritten during scene activation, ensuring more reliable data persistence.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ce1e57ca-25a0-46ff-95fc-be8c430c43d5

📥 Commits

Reviewing files that changed from the base of the PR and between dc33d7e and 1618115.

📒 Files selected for processing (7)

• NOTES.md
• README.md
• src/prune/app/app.cpp
• src/prune/scene/artillery/artillery_scene.cpp
• src/prune/scene/platformer/platformer_scene.cpp
• src/prune/scene/scene.hpp
• src/prune/scene/simple_shooter/simple_shooter_scene.cpp

---

📝 Walkthrough

Walkthrough

The PR separates scene activation from default content creation across the scene subsystem. The Scene interface in scene.hpp gains clarifying documentation comments on on_enter() and new_scene(). All three scene subclasses (ArtilleryScene, PlatformerScene, SimpleShooterScene) have their on_enter() implementations stripped of the new_scene() call, leaving only a comment stub. App::App and App::run now call m_scene->new_scene() explicitly after SceneFactory::create() and before m_scene->on_enter(). NOTES.md and README.md are updated to reflect the new requirement and completed tasks.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• deanblackborough/Prune#50: Modifies the same App::run() scene loading path in app.cpp, touching the same scene lifecycle flow around load_from_file() and on_enter().

Suggested labels

enhancement

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch release-fixes-multi-select

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}