Skip to content

Fix CI generation, resolve all CI issues#488

Merged
bikeshedder merged 3 commits into
deadpool-rs:mainfrom
CathalMullan:ci
Jul 13, 2026
Merged

Fix CI generation, resolve all CI issues#488
bikeshedder merged 3 commits into
deadpool-rs:mainfrom
CathalMullan:ci

Conversation

@CathalMullan

Copy link
Copy Markdown
Contributor

The recent changes in #482 weren't applied to the CI generation layer. First commit here doesn't change any behavior, just copies the changes to the jsonnet layer.

Second commit resolves all the pre-existing CI issues. Mainly version bumps and feature re-exports.

@CathalMullan

CathalMullan commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Hmm, CI networking seems flaky for the one failed job. Could try bumping CARGO_NET_RETRY.

@CathalMullan

Copy link
Copy Markdown
Contributor Author

Ah, seems the flaky CI was related to a Cargo bug fixed in 1.96.1: https://blog.rust-lang.org/2026/06/30/Rust-1.96.1

@bikeshedder

Copy link
Copy Markdown
Collaborator

I like those tagged versions. ❤️

Is there a good way to check the versions of the used actions so they can be updated more easily?

@bikeshedder bikeshedder added T-admin Type: Administrative/Deployment Task github_actions Pull requests that update GitHub Actions code labels Jul 13, 2026
@bikeshedder
bikeshedder merged commit 8b54164 into deadpool-rs:main Jul 13, 2026
132 of 133 checks passed
@CathalMullan

Copy link
Copy Markdown
Contributor Author

@bikeshedder I've used pinact on my own projects, which can print a diff compared to the latest.

Only issue here is due to the generated CI approach, it complains about the lack of comments.

> pinact run --update --diff
.github/workflows/deadpool-diesel.yml:12
-       - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
+       - uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
...

@CathalMullan
CathalMullan deleted the ci branch July 13, 2026 21:22
@bikeshedder

Copy link
Copy Markdown
Collaborator

I wish there was a better way than generating the actions. GitHub Actions are really a bummer to work with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code T-admin Type: Administrative/Deployment Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants