Maker info windows toggle - #4
Open
pyrodogg wants to merge 2 commits into
Open
Conversation
Author
|
Also added update to filter warps by world name if defined in WarpMarkers.js |
Owner
|
Hi! Sorry for the very late reply. I started a complete re-write of WarpMarkers last fall to make it much easier to include support for other warp-plugins. Unfortunately some other projects I'm involved in needed attention, so it has yet to be completed. At the moment I'm applying for new jobs, so I have no time for this. But as soon as I get settled in to a new job, I'll get back to WarpMarkers. -Brendan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This quick addition makes the markers behave as toggles instead of only opening the info window. I think it has a more logical flow instead of navigating to the fade-in 'x' button on the info window itself. The native close button is still there and fully functional.