v1.1.4 — honest media, plus the two bugs recapturing it found - #47
Merged
Conversation
The report header reads its own version from the jar manifest; without addDefaultImplementationEntries the manifest carried no Implementation-Version, so every generated report was stamped "dev".
trendHistory was only put on the report inside the baseline-write branch, so the diff run you actually do day to day rendered an empty trend chart. The history lives in the baseline either way; hand it to the report there too, without appending the current run (it is not a baseline entry).
… 1.1.4 report tools/capture-media.js drives a real generated report in a browser and writes exactly the files the docs embed, so the media cannot drift from what the report renders. The old PNGs were captured on 0.7.1 — four releases of UI ago. Also untracks the module's regenerated report, which is a test byproduct.
Fresh start.spring.io app (429 beans, 436 edges, one real cycle, a ghost, three baseline writes) so the trend and thread cards have real data. The served 0.10.0 copy is replaced.
mvn test rewrites wiredoctor-autoconfigure/wiredoctor-report.html on every run, so it showed up as a diff in unrelated work. It is a byproduct, not a deliverable; the sample/ reports are the published ones.
Every number, bean name and verdict in the tour now comes from the run the screenshots were taken from, and the 0.7.1 disclaimer is gone. README leads with the tour GIF, sample/README describes the new set, and the trend guide says the chart works on diff runs now.
Maven, Gradle and both docs copies. Only the coordinates move; the "(v1.1.0)" / "(v1.1.3)" feature markers stay, they say when a feature landed, not what to depend on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README hero and every screenshot in the report tour were captured on 0.7.1 — four releases of UI ago. This release recaptures all of it from a real 1.1.4 run, and recapturing it turned up two genuine bugs, both fixed here.
Fixed
trendHistorywas only put on the report inside thebaseline-write=truebranch, so the run you actually do day to day — diff mode, gates armed — rendered "Need at least 2 baseline writes" even with a full history committed in the baseline. The history is now handed to the report in diff mode too; the current run is not appended, because it is not a baseline entry. 2 new tests.dev. The header chip reads the version from the jar manifest, and the build never wrote anImplementation-Versioninto it.addDefaultImplementationEntrieson maven-jar-plugin fixes it for every user, not just for these screenshots.Media
All captured from one run: start.spring.io app on Boot 4.1.x, 429 beans / 436 edges, a real setter-injected cycle, a slow
@PostConstructbean, an untouched exporter, first-touch ghost tracking on, three baseline writes then a diff run.tools/capture-media.jsdrives a real report in a headless browser and writes exactly the filenames the docs embed, so the media cannot silently drift againsample/v1.1.4/is the published set (report, JSON, baseline, diff, ghost report, gate status) and is what the live "open this report" links point atDocs
1.1.4(Maven + Gradle, README and both docs copies). Feature markers like "(v1.1.0)" / "(v1.1.3)" are left alone — they record when a feature landedsample/README.mdtable, trend guide notes the diff-run fiximages/dump andwiredoctor-autoconfigure/wiredoctor-report.html, whichmvn testrewrites on every runTested
mvn test— 261 tests in wiredoctor-autoconfigure, 11 in wiredoctor-actuator, 0 failuresImplementation-Version: 1.1.4, the report header rendersv1.1.4, and a diff run exposes exactly the 3 baseline trend entriesNot in this PR
Publishing 1.1.4 to Maven Central. The
Publishworkflow staysworkflow_dispatch-only; the README now advertises 1.1.4, so it resolves once that runs.