feat: add protein sampling benchmark#729
Draft
lwalew wants to merge 1 commit into
Draft
Conversation
lwalew
force-pushed
the
feat/add-protein-sampling-benchmark
branch
from
July 23, 2026 14:54
41a533e to
aae2a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
Summary
Migrates the protein sampling benchmark from the MLIP Audit suite into ml-peg,
introducing a new top-level
biomoleculescategory.The benchmark runs short molecular dynamics simulations for a set of small proteins
(chignolin 1UAO, Trp-cage 2JOF, orexin beta 1CQ0), collects the sampled backbone
(phi/psi) dihedral angles, and compares their distributions to reference
distributions. Three metrics are reported (all lower-is-better, averaged over residue
types and stable systems):
distributions.
any reference data point.
This is a table-only benchmark (no primary plot), consistent with the migration spec.
The underlying
SamplingBenchmarklogic lives in the pinnedMLIP Audit package (
mlpeg-migrationbranch); ml-peg wires it up through a thin
MlPegSamplingBenchmarkadapter thatdisables
skip_if_elements_missing(ml-peg's ASE calculators do not expose the set ofsupported elements).
Notes for reviewers
biomoleculescategory (app YAML, docs category page, docstoctree entry).
mlipauditwiring (pyproject.tomloptional extra +conflict +
tool.uv.sources, and themlip_auditframework entry inframeworks.yml). This wiring overlaps with other in-flight MLIP Audit migrationPRs (e.g. ring planarity, protein folding) and is expected to be reconciled at
merge.
Linked issue
Resolves #726
Progress
Testing
Static/local validation only so far: all new Python modules compile and the full
pre-commitsuite passes (ruff-check, ruff-format, numpydoc-validation, etc.).End-to-end runs across models are pending upload of the input data to S3
(
inputs/biomolecules/protein_sampling/protein_sampling.zip), which has not beenperformed as part of this PR.
New decorators/callbacks
None. Uses the existing
build_tabledecorator andBaseApptable-only layout.