Skip to content

chore: bump Homebrew/actions/setup-homebrew, fixes #58 - #60

Merged
stasadev merged 4 commits into
mainfrom
20260404_nodejs_24
Apr 6, 2026
Merged

chore: bump Homebrew/actions/setup-homebrew, fixes #58#60
stasadev merged 4 commits into
mainfrom
20260404_nodejs_24

Conversation

@rfay

@rfay rfay commented Apr 5, 2026

Copy link
Copy Markdown
Member

The Issue

  • Node 20 is deprecated, but the homebrew installer tries to use it, so all add-ons have warnings.
  • First run of the test failed markdown link tests, so I added the GItHUB_TOKEN env to try to solve it.

@rfay
rfay requested review from julienloizelet and stasadev April 5, 2026 01:02
@stasadev stasadev changed the title fix: Work around github warnings about nodejs 20 with homebrew installer fix: Work around github warnings about nodejs 20 with homebrew installer, fixes #58 Apr 6, 2026
@stasadev stasadev changed the title fix: Work around github warnings about nodejs 20 with homebrew installer, fixes #58 chore: bump Homebrew/actions/setup-homebrew, fixes #58 Apr 6, 2026
Comment thread action.yaml
using: "composite"
steps:
- uses: Homebrew/actions/setup-homebrew@4cdec6dc3e14702214632b392c91a7cc283fbc8a #no release tags available
- uses: Homebrew/actions/setup-homebrew@675fcd27b59e54d310c5484c8c27c01d03da660c #no release tags available

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stasadev stasadev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@stasadev
stasadev merged commit c96b7dd into main Apr 6, 2026
20 checks passed
@stasadev
stasadev deleted the 20260404_nodejs_24 branch April 6, 2026 16:55
@stasadev

stasadev commented Apr 6, 2026

Copy link
Copy Markdown
Member

No warnings:

https://github.com/ddev/ddev-phpmyadmin/actions/runs/24041373992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homebrew/actions/setup-homebrew uses Node.js v20

2 participants