Change shebang to use env for bash, fixes #27 - #28
Merged
Conversation
rfay
approved these changes
Sep 4, 2025
rfay
left a comment
Member
There was a problem hiding this comment.
Thanks!
I thought we had this fixed in so very many places.
How did you encounter this? On a system without /bin/bash?
Contributor
Author
|
I watched an informative YouTube video on the importance of the shebang for bash scripts. Then I searched my ddev projects to make sure all of my commands were using the right setting. The phpmyadmin addon was the only one I found that had the /bin/bash set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
How This PR Solves The Issue
Changes the shebang line to use the env program to determine the user's path to bash.
Manual Testing Instructions
Automated Testing Overview
No changes to existing tests as this would work with existing test.
Release/Deployment Notes
No expected ramifications to other code