Skip to content

Change shebang to use env for bash, fixes #27 - #28

Merged
rfay merged 1 commit into
ddev:mainfrom
shelane:patch-1
Sep 4, 2025
Merged

Change shebang to use env for bash, fixes #27#28
rfay merged 1 commit into
ddev:mainfrom
shelane:patch-1

Conversation

@shelane

@shelane shelane commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

The Issue

How This PR Solves The Issue

Changes the shebang line to use the env program to determine the user's path to bash.

Manual Testing Instructions

ddev add-on get https://github.com/<user>/<repo>/tarball/<branch>
ddev restart

Automated Testing Overview

No changes to existing tests as this would work with existing test.

Release/Deployment Notes

No expected ramifications to other code

@rfay rfay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I thought we had this fixed in so very many places.

How did you encounter this? On a system without /bin/bash?

@rfay rfay changed the title Change shebang to use env for bash Change shebang to use env for bash, fixes #27 Sep 4, 2025
@rfay
rfay merged commit ded9005 into ddev:main Sep 4, 2025
2 checks passed
@shelane

shelane commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

I watched an informative YouTube video on the importance of the shebang for bash scripts. Then I searched my ddev projects to make sure all of my commands were using the right setting. The phpmyadmin addon was the only one I found that had the /bin/bash set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants