Skip to content

perf: release the GIL around libdeflate compress/decompress #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcwatson merged 1 commit into from
Jun 23, 2026
+11 −5
Merged

perf: release the GIL around libdeflate compress/decompress #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/_deflate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ static PyObject *compress(Py_buffer *data, int compression_level,
return PyErr_NoMemory();
}

size_t compressed_size = (*compressfunc)(compressor, data->buf, data->len,
PyByteArray_AsString(bytes), bound);
char *outbuf = PyByteArray_AsString(bytes);
size_t compressed_size;
Py_BEGIN_ALLOW_THREADS;
compressed_size = (*compressfunc)(compressor, data->buf, data->len, outbuf, bound);
Py_END_ALLOW_THREADS;
libdeflate_free_compressor(compressor);

if (compressed_size == 0) {
Expand Down Expand Up @@ -62,11 +65,14 @@ static PyObject *decompress(Py_buffer *data, unsigned int originalsize,
return PyErr_NoMemory();
}

char *outbuf = PyByteArray_AsString(output);
size_t decompressed_size;
struct libdeflate_decompressor *decompressor = libdeflate_alloc_decompressor();
enum libdeflate_result result = (*decompressfunc)(
decompressor, data->buf, data->len, PyByteArray_AsString(output), originalsize,
&decompressed_size);
enum libdeflate_result result;
Py_BEGIN_ALLOW_THREADS;
result = (*decompressfunc)(decompressor, data->buf, data->len, outbuf, originalsize,
&decompressed_size);
Py_END_ALLOW_THREADS;
libdeflate_free_decompressor(decompressor);

if (result != LIBDEFLATE_SUCCESS) {
Expand Down
Loading