Skip to content

L3 VPP Aggregator Capacity Scoping & Typo Fixes #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcplatforms wants to merge 1 commit into
base: main
Choose a base branch
from
Open

L3 VPP Aggregator Capacity Scoping & Typo Fixes #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions services/03-vpp-aggregator/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ app.get('/capacity/available', authenticateToken, async (req, res) => {
if (safetyContext && typeof safetyContext === 'string') {
try {
const context = JSON.parse(safetyContext);
physicsScoreVal = parseFloat(safeFloat(context.physics_score, 1.0));
confidenceScoreVal = parseFloat(safeFloat(context.confidence_score, 1.0));
physicsScoreRaw = parseFloat(context.physics_score);
confidenceScoreRaw = parseFloat(context.confidence_score);

@cursor cursor Bot Jul 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing scores zero capacity

Medium Severity

Replacing safeFloat-backed parsing with bare parseFloat on context.physics_score and context.confidence_score leaves missing or invalid fields as NaN, which the multiplier path maps to 0.0 and drives physicsMultiplier to zero. The same inputs still surface as 1.0000 in responses via safeFloat, so capacity can be wiped while telemetry looks healthy, and a single valid score no longer derates capacity the way it did when the missing side defaulted to 1.0.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6bbda96. Configure here.


// High-Fidelity Standard: (physics_score > 0.95 OR confidence_score > 0.95)
isHighFidelity = physicsScoreRaw > 0.95 || confidenceScoreRaw > 0.95;
Expand Down Expand Up @@ -287,8 +287,8 @@ const updateGlobalCapacity = async () => {
if (context.fleet_id) {
lockedFleetId = context.fleet_id;
}
rawPhysicsScore = parseFloat(safeFloat(context.physics_score, 1.0));
confidenceScore = parseFloat(safeFloat(context.confidence_score, 1.0));
rawPhysicsScore = parseFloat(context.physics_score);
rawConfidenceScore = parseFloat(context.confidence_score);

// Sentinel Fidelity logic: Prioritize explicit flag (boolean, string, or integer)
isSentinelFidelity = context.is_sentinel_fidelity === true || context.is_sentinel_fidelity === 'true' || context.is_sentinel_fidelity === 1 || rawPhysicsScore > 0.99;
Expand Down