Convert clan-state.service BehaviorSubjects to Angular signals - #617
Open
dcaslin wants to merge 1 commit into
Open
Convert clan-state.service BehaviorSubjects to Angular signals#617dcaslin wants to merge 1 commit into
dcaslin wants to merge 1 commit into
Conversation
Converted 17 BehaviorSubjects in ClanStateService to signals and updated 16 consumer components/templates. Replaced .next() with .set(), .getValue() with direct signal calls, removed async pipe from templates, and converted component subscriptions to effect(). Also converted local BehaviorSubjects in 4 child components to signals. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClanStateServiceto Angular signals (signal()).next()→.set(),.getValue()→(), removed| asyncpipe from templates.subscribe()patterns in 4 child components toeffect()with local signal stateAsyncPipefrom 8 components that no longer need itTest plan
npm run test:ci— 254 tests pass, coverage thresholds metnpm run lint— 0 errors🤖 Generated with Claude Code