Adopt Angular signals for reactive state - #611
Merged
Merged
Conversation
Convert BehaviorSubjects to WritableSignals in AppStateService, ChildComponent, and 7 service-level loading flags. Replace | async pipe with signal() reads in 54 templates. Replace .next() with .set() and .getValue() with () across 24 TS files. Remove AsyncPipe import from 11 components that no longer need it. Convert FriendsComponent members to signal with effect() for reactive state derivation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppStateServiceBehaviorSubjects toWritableSignal(6 fields: disableAds, debugmode, favoritesList$, favoritesMap, hiddenMilestones, hiddenClanMilestones)ChildComponent.loadingfromBehaviorSubjecttosignal(false)loadingBehaviorSubjects to signals in 7 services/components (StreamingService, GearService, ClanStateService, FriendStarComponent, PerkbenchComponent, DimSyncService, MarkService)field | asyncwithfield()signal reads.next()with.set()and.getValue()with()across 24 TS filesAsyncPipeimport from 11 components that no longer use itFriendsComponent.membersto signal, useeffect()for reactive derivation fromfavoritesList$What stays as Observable
PlayerStateService(complex: private subjects + public.asObservable()pattern)ClanStateServicenon-loading subjects (many BehaviorSubjects with rich usage)GearFilterStateServiceobservablesVerification
ng build— clean ✅ng build --configuration production— 2.98 MB initial bundle ✅npm run lint— 0 errors ✅Test plan
🤖 Generated with Claude Code