Cleanup: dead code, budgets, CI bundle reporting - #607
Merged
Conversation
- Remove duplicate parseClanInfo() from gear-parser.service.ts (dead code, identical copy lives in parse.service.ts) - Bump bundle size budget from 2.75/3.25 MB to 3.1/3.5 MB for MDC migration - Raise karma coverage thresholds to just below current levels as a ratchet - Add bundle size reporting to CI (GitHub Step Summary) - Update modernization-plan.md: mark Phase 3 and 5 done, reflect Node 22 and manifest tool changes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parseClanInfo()fromgear-parser.service.ts(dead code — identical copy inparse.service.tsis the one callers use)Test plan
npm run build:prod— passes with no budget warningnpm run test:ci— 185/185 pass, coverage meets thresholdsnpm run lint— 0 errors🤖 Generated with Claude Code