Skip to content

[codex] Fix Foundations review findings#6

Merged
dbtlr merged 1 commit into
mainfrom
sga-75-foundations-review-fixes
Jun 19, 2026
Merged

[codex] Fix Foundations review findings#6
dbtlr merged 1 commit into
mainfrom
sga-75-foundations-review-fixes

Conversation

@dbtlr

@dbtlr dbtlr commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • make unimplemented saga service lifecycle commands fail instead of reporting success
  • add structured output support for implemented CLI commands using --format json|jsonl|ids
  • improve saga doctor handling for malformed bindings, Postgres connectivity vs migration state, and observed service health

Queued follow-ups

  • SGA-77 Harden service process and log status once supervisor support exists
  • SGA-78 Enforce doctor engine versions against package.json engines
  • SGA-79 Add an end-to-end init registration test against real Postgres

Verification

  • pnpm --filter @saga/cli test
  • pnpm --filter @saga/cli check
  • pnpm --filter @saga/runtime test && pnpm --filter @saga/runtime check
  • pnpm --filter @saga/db check
  • pnpm exec vp check --fix
  • pnpm run verify
  • pnpm run build
  • local Postgres smoke: saga init + saga doctor
  • service smoke: saga service run + saga service status records/json

@dbtlr dbtlr marked this pull request as ready for review June 19, 2026 20:27
@dbtlr dbtlr merged commit 3d9bdcb into main Jun 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant