Repository navigation
Fix catalog proposal commit failing in CI (no git identity) - #18
Merged
Merged
Conversation
checkout_branch produces a fresh clone with no local git identity, and its
docstring promises the checkout is "ready to propose from". On a host without a
global git config (CI runners, containers) a commit into it fails with exit 128
("empty ident name") — which is why test_a_proposal_pushes_back_to_the_models_own_repo
failed in GitHub Actions but passed on developer machines that have a global
identity.
Set a local user.name/user.email on the checkout (the same identity publish()
already commits under), so a commit into a materialised proposal branch works
regardless of the host's global git config. Pre-existing latent bug, surfaced by
a CI run; unrelated to the docs/MCP changes.
Verified by reproducing the CI environment locally (GIT_CONFIG_GLOBAL=/dev/null,
no GIT_AUTHOR_* set): the catalog suite fails before the fix and passes after.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.