Reserve space for the async status message to prevent layout shift - #289
Merged
Merged
Conversation
The 'Together, N athletes logged X miles this month!' message is injected asynchronously into #messages, which previously had no height, causing the CTA button and screenshot below it to jump down once the message loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Together, N athletes logged X miles this month!" message is fetched asynchronously and injected into
#messages, which had no reserved height. This caused the CTA button and screenshot below it to visually jump down once the message loaded. Reserves min-height for #messages to prevent the shift, matching the same fix applied to discord-strava.