Add price metric and longer timeframes to stock chart - #244
Conversation
There was a problem hiding this comment.
💡 Codex Review
InvestmentsView/server/src/index.js
Lines 559 to 567 in 735b663
The aggregation path drops priceCad/priceNative when building combined series, so responses for symbol views that span multiple accounts no longer contain any price data. The chart code relies on those fields to populate the new Price metric and, when they are missing, it falls back to the original P&L values, rendering a "Price" chart that actually shows P&L. Include price values in the aggregated points (and summary) so the Price option works for aggregated symbol views.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex , can you fix it? |
|
Summary
Testing
|
Summary
targetSymbolso total P&L calculations no longer throw aReferenceErrorTesting
Codex Task