Skip to content

Enable locking available ships - added reduce credit at start of startProject event and in catch handling revert the available ships - #28

Open
PREMPRAKASHSINGH wants to merge 4 commits into
daytimedrinkingclub:mainfrom
PREMPRAKASHSINGH:fix_enableLockingAvailableShips_prem
Open

Enable locking available ships - added reduce credit at start of startProject event and in catch handling revert the available ships#28
PREMPRAKASHSINGH wants to merge 4 commits into
daytimedrinkingclub:mainfrom
PREMPRAKASHSINGH:fix_enableLockingAvailableShips_prem

Conversation

@PREMPRAKASHSINGH

@PREMPRAKASHSINGH PREMPRAKASHSINGH commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Closes #14

  • Added reduce available ship in startProject event.
  • Added a catch handling to revert the available ships in case of any error.
  • Commented the code for reduce available credits in handleOnboardingToolUse function which used to run at project completed status

await updateUserProfile(userId, profilePayload);
}

// removing deduct available ships from here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the unused code instead of committing, rest looks good

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed commented code. Please review now.

@PREMPRAKASHSINGH

Copy link
Copy Markdown
Contributor Author

@ptmaroct Cleaned up the commented code. Please check.

@PREMPRAKASHSINGH

Copy link
Copy Markdown
Contributor Author

@ms4n @ptmaroct resolved conflicts, please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable locking available ships

2 participants