Repository navigation
fix: harden import overwrites, corrupt-file saves and reachability refresh - #1
Merged
Merged
Conversation
dawiisss
marked this pull request as ready for review
October 31, 2026 00:30
…fresh Rebuilds the remaining changes from #1 on top of v1.6.0. - Give a connection a new ID when an overwrite import changes where it authenticates (protocol, host, port, user, RDP domain or gateway, or SSH tunnel server), and delete the password saved under the old ID. - Report a corrupt configuration file that could not be backed up, and refuse to save over it. - Discard results from a superseded reachability check. - Run every test target in CI even after one fails.
dawiisss
force-pushed
the
fix/review-hardening-2026-10-30
branch
from
October 31, 2026 12:38
6a64688 to
315aa09
Compare
dawiisss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilt on top of v1.6.0. This keeps the changes from the original version of this PR that were not already released.
cargo testruns with--no-fail-fast.Dropped from the original version
~/.ssh/confighosts by alias: v1.6.0 importsHostName,ProxyJumpand forwards into the connection instead. Using the alias as well would make ssh apply each forward twice, and reachability checks would fail on alias names.Validation
cargo fmt --check,cargo clippy --all-targets --all-features -- -D warningsandcargo test --all-targetspass locally. New tests cover credential ID rotation (including SSH tunnel changes) and refusing to save over a corrupt file that could not be backed up.