Protection against non-existing property "hiddensections" in $COURSE - #7
Open
matcho wants to merge 1 commit into
Open
Protection against non-existing property "hiddensections" in $COURSE#7matcho wants to merge 1 commit into
matcho wants to merge 1 commit into
Conversation
| $thissection = $sections[$mod->sectionnum]; | ||
|
|
||
| if ($thissection->visible || !$COURSE->hiddensections || | ||
| if ($thissection->visible || (property_exists($COURSE, "hiddensections") && !$COURSE->hiddensections) || |
Owner
There was a problem hiding this comment.
Hmm... I'll have to look at this in more detail, but I'd be wanting to use isset(), not property_exists (possibly also wanting to use empty(), but would have to figure out the logic of the line of code first anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
On my Moodle 3.0 instance, I get a warning about $COURSE->hiddensections not existing.
Here's a proposal to avoid this.
Thanks,
Mathias