Skip to content

Add option to embed checklist - #10

Open
sh-csg wants to merge 1 commit into
davosmith:masterfrom
sh-csg:embed-option
Open

Add option to embed checklist#10
sh-csg wants to merge 1 commit into
davosmith:masterfrom
sh-csg:embed-option

Conversation

@sh-csg

@sh-csg sh-csg commented Oct 30, 2025

Copy link
Copy Markdown

This adds an option to embed the checklist directly in the block

@davosmith

Copy link
Copy Markdown
Owner

Thanks for this @sh-csg - it looks great.

One thing I'd want to see, before merging the change, would be a simple Behat test that confirms it is working as expected and that it continues to work during future upgrades (I'm aware that the old code here does not have any existing Behat test coverage, but I'm wanting to improve on that as time goes on).

Something simple that generates a checklist with a few items, adds the block to a course, ticks off a couple of items in the checklist, then refreshes the page and confirms that it stays updated. Most of that can be easily cribbed from the existing Behat tests for mod_checklist.

Would it be possible for you to add such a test?

@sh-csg
sh-csg force-pushed the embed-option branch 2 times, most recently from 8b19ca7 to 88bc130 Compare November 5, 2025 12:41
@sh-csg

sh-csg commented Nov 5, 2025

Copy link
Copy Markdown
Author

Hi @davosmith ,
thanks a lot for your feedback! I added a small behat test and changed the GHA to install mod_checklist (for being able to use the steps defined there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants