Conversation
…S-IN-UTF8-MODE is enabled.
|
I've just done a quick test with this now, and it still didn't seem to work, but it's possible I haven't done the build correctly or something like that. I'll try and take a closer look later tonight, and maybe put together a simple test case. |
|
Don't panic yet! I think I just messed up my checkout of the PR. Building again now. |
|
OK, I can confirm it's working perfectly now! Sorry for the false alarm. |
Owner
Author
|
Glad to hear it works! No worries about the false alarm - I created the PR just before heading out the door to work so I'm only getting back to it now on my lunch break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem turned out to be fairly trivial - the state of GNOW is updated by the remote-to-local translation function, so checking it before that was called (to decide if we should do utf8 things instead) meant that we were checking the old version of GNOW, not what it was going to be. Instead make the same decision rtoxlat does but only for 7 bit characters.