Upgrade redis to 6.1.0 and preserve v5 semantics where needed#1584
Open
davidmerfield wants to merge 1 commit into
Open
Upgrade redis to 6.1.0 and preserve v5 semantics where needed#1584davidmerfield wants to merge 1 commit into
davidmerfield wants to merge 1 commit into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
5.11.0to6.1.0and adopt the v6 migration guidance (RESP defaults, Node.js engine bump).Description
redisdependency to6.1.0and added anengines.nodeentry>=20.0.0inpackage.jsonto reflect v6 Node requirement.RESP: 3but explicitly setmaintNotifications: "disabled",commandOptions: { timeout: undefined }, andsocket.keepAliveInitialDelay: 5000inapp/models/redis.jsto preserve v5 defaults for maintenance and timeouts.RESP: 2and setcommandOptions/socket.keepAliveInitialDelayto v5 defaults inapp/dashboard/util/session.js,app/dashboard/log-in/rateLimit.js, andscripts/db/redis-latency-profile.jsto avoid accidental RESP3-shaped reply changes for those consumers.unstableResp3*,legacy(), Sentinel/cluster/pool constructors, specific commands called out in the migration guide) and found no direct usages requiring changes.Testing
npm install --ignore-scriptsto updatenode_modules; installation completed successfully. (succeeded)node -e "console.log(require('redis/package.json').version)"and saw6.1.0. (succeeded)NODE_PATH=app node -e "require('./app/models/redis')(); console.log('models redis ok')"to ensure the new client loads; this completed and printedmodels redis ok. (succeeded)git diff --checkto validate diffs; no whitespace/errors reported. (succeeded)npm test, but the repository test harness invokes Docker and this environment does not have Docker available, so the full test suite was not run here. (not run)If CI runs the full suite (with Docker/Redis), it should detect any remaining behavioral regressions related to RESP3 type mapping or prototype normalization; the changes in this PR intentionally preserve v5 reply/timeouts for risky code paths while letting the main client use RESP3 with explicit v5 defaults where required.
Codex Task