Add post sort control to template editor#1325
Open
davidmerfield wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
locals.sort_by/locals.sort_orderare missing by providing sensible defaults.sort_byandsort_orderwhen the select is submitted so templates receive complete sorting metadata.Description
app/dashboard/site/template/sort-options.jswith the four required options and their exact labels and mapping values.app/dashboard/site/template/load/index-inputs.jsto always append a select-style control (matching existing select rendering) namedsort_by, using defaultssort_by: "date"andsort_order: "desc"when locals are absent.selected.app/dashboard/site/template/save/layout-inputs.jsto map the submitted selectvalueback into bothreq.locals.sort_byandreq.locals.sort_order, falling back to the same defaults when the submitted value is missing or invalid.Testing
Codex Task