Revamp get_view_url()

[james-cnz]

I think this should improve subsection URLs.

[james-cnz]

I didn't notice the subsection display mode option. I've added support for that now.

[davidherney]

Hi @james-cnz

Please explain the changes you made and how I can validate them so I can test them directly before approving. Trying to deduce everything directly from the code takes me too long.

Gracias

Saludos

[james-cnz]

Hi @davidherney,

It's basically for two things:
Subsection links in the course index: At the moment, they go to the subsection page, even if the subsection is set to show on the course page. It's changed to display the subsection on the course page in this case.
Returning to the subsection from Edit settings: At the moment it just returns to the relevant course page, but doesn't scroll to the subsection. It's changed to also scroll to the subsection. (I think this might depend on MDL-84045, so you might need a version of Moodle after Feb 19 to see this fix.)
[EDIT: Oh, subsection permalink too. At the moment, they go to the subsection page always (in Moodle <=5.1). With the change it displays the subsection on the course page where appropriate.]