Add agentic harness program - #9
Open
david-hoffman wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #6
Refs #5
Refs #8
Change summary
Implemented the repository-local agentic harness across Phases 0 through 4.
ci-required.Phase
Agent workflow evidence
Issue #5 includes committed
test-author,implementer,adversarial-reviewer, andnumerics-reviewermetadata for thesplit_imgproduct source change.Issue #8 includes committed
test-author,implementer,adversarial-reviewer, andnumerics-reviewermetadata for the NumPy 2 doctest compatibility change.Issue #6 includes committed
scout,ci-triager,release-guard, andadversarial-reviewermetadata for the high-risk harness rollout.Tests and commands
python -m pytest --doctest-modules dphtools tests: failed before issue Fix NumPy 2 doctest scalar compatibility #8 fix with 3 doctest failures; passed after with 43 passed, 3 warnings.make harness-check: passed.python -m pytest -q tests/test_utils.py::test_split_img tests/test_utils.py::test_split_img_random: 12 failed before issue Fix NumPy 2 split_img compatibility #5 fix, 12 passed after.python -m pytest -q tests: 36 passed, 3 warnings.make coverage: passed; coverage gate passed; diff coverage gate passed for 4 changed executable product lines.make package: passed;twine checkpassed.make check: passed.python scripts/agent_harness/downstream_smoke.py: passed with no known downstream consumers configured.Coverage
Scientific, hardware, or numerical impact
Facts:
dphtools/utils/__init__.py.split_imgnow usesnp.prodinstead of the removednp.productalias.modenow returns the documented Pythoninttype instead of a NumPy scalar.slice_makernow emits Python integer slice bounds.scaleruntime behavior is unchanged; doctest examples cast extrema for stable scalar display.Assumptions:
np.prod(divisors)preserves the intended tile-count product for supported NumPy versions.Guesses:
modeorslice_makeroutputs.Public API impact
modenow matches its documentedintreturn type.slice_makerreturns equivalent slices with Python integer bounds.Downstream impact
No downstream consumers were discovered.
downstream_smoke.pynow passes with an explicit no-known-consumer message.Release impact
Release workflow publishing semantics remain tag-triggered, but publishing is now split across protected environments and includes installed-artifact smoke testing.
Human/admin decisions needed
Human/admin approval is required for this high-risk PR because it changes branch governance, required CI, CODEOWNERS, release workflow behavior, and GitHub release environments. GitHub settings were configured via API and documented under
docs/generated/.