Skip to content

Adding time of schedule scan to Status field. - #141

Open
sebastiancepeda wants to merge 2 commits into
dave-theunsub:masterfrom
sebastiancepeda:patch-1
Open

Adding time of schedule scan to Status field.#141
sebastiancepeda wants to merge 2 commits into
dave-theunsub:masterfrom
sebastiancepeda:patch-1

Conversation

@sebastiancepeda

Copy link
Copy Markdown

Closes #140

@Neustradamus

Copy link
Copy Markdown

@dave-theunsub: What do you think about this PR?

@dave-theunsub

Copy link
Copy Markdown
Owner

That looks nice. I recommend changing the "at" - either leaving it out or using "@" or maybe you can think of something else. This way we don't need everyone to update the language files for the change of this one sentence as the change is minor.

@dave-theunsub

Copy link
Copy Markdown
Owner

If it's done like this, we won't need new translations:

    if ($scan) {
        $hour_spin_scan->set_value($scan_hour);
        $min_spin_scan->set_value($scan_minute);
        $scan_apply_btn->set_sensitive(FALSE);
        $scan_remove_btn->set_sensitive(TRUE);

        my $statement = _('A daily scan is scheduled');
        my ($status_line_text) =
          sprintf( "%s (%02d:%02d)", $statement, $scan_hour, $scan_minute );
        $scan_status_label->set_text($status_line_text);
    }

Anything between the _( ) portion ends up needing translation. This way we just work around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More information for the status field

3 participants