Name the app the way the app list reads it - #271
Merged
Conversation
The 3.5 line renamed the app because it was the odd one out among the two-factor providers under Apps, and because its summary only said the name a second time. Both belong here as well: a Nextcloud 32 shows this line in the same list. What differs is the reach. The app store overwrites an app's name only from the newest stable release it holds, so nothing this line uploads will move the store page — the new name shows up in the installed apps list of a Nextcloud 32 and nowhere else. The admin settings heading is a translated string here too, and reads English until Transifex has the new one. Signed-off-by: Olav Seyfarth <olav@seyfarth.de> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nursoda
added
the
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every change on main reaches this branch. The 3.5 line renamed the app because
"Two-Factor email provider" was the odd one out among the two-factor providers a
server admin sees under Apps, and because the summary only said the name a second
time. A Nextcloud 32 shows this line in that same list, so both changes belong
here.
What differs is the reach. The app store overwrites an app's name only from the
newest stable release it holds (
AppImporter._should_update_everything), sonothing this line uploads will move the store page: the new name arrives in the
installed apps list of a Nextcloud 32 and nowhere else. The admin settings heading
is a translated string here too, and reads English until Transifex has the new one.
🤖 Generated with Claude Code, verified, tweaked and approved by @nursoda.