335 ty-specific changes#355
Draft
jackleland wants to merge 6 commits into
Draft
Conversation
jackleland
marked this pull request as draft
March 24, 2026 14:00
Contributor
|
I thought this had already been merged. I've already done the fork. Can we carry this over to the new repo datasig-ac-uk/roughpy-jax |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is specifically the changes needed for ty to run cleanly, some of it is useful bug catching, some of it is python type checking particularities that doesn't necessarily result in cleaner code but does pass the checker.
One thing is that I had to split up the dataclass wrappers as ty really didn't like it.
I'm still going through the changes needed on algebra, but I'm hoping to have that in here v. soon