[report 1862] GROK-20815: Widgets: Implement the isFiltering contract in RadioButtonFilter, make the no-selection state non-throwing, and give each filter card a unique radio-group name - #4027
Closed
datagrokci[bot] wants to merge 2 commits into
Conversation
added 2 commits
September 2, 2026 04:55
…tead of nullable name in dim reduction and MCL flows
…nFilter, make the no-selection state non-throwing, and give each filter card a unique radio-group name
Contributor
|
again, this PR somehow decided to have 2 fixed instead of 1 - investigating why, closing until we have a good 1 fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding or clicking a "Single Choice" (radio) filter threw "Cannot read properties of null (reading 'getAttribute')" from every card with no checked radio: the filter claimed isFiltering unconditionally, dereferenced the checked input without a null check, and all cards shared one radio-group name so a click in one card cleared its siblings.
The fix implements the Filter.isFiltering contract, makes the no-selection state return null/empty, and derives group names and ids from static counters.
Diff: +19/-9 · 2 files
Verified: reproduction recipe replayed on the patched build — the original error no longer fires
Full analysis: GROK-20815