[report 1687] GROK-20814: EDA: Resolve target table views by DataFrame identity instead of nullable name in dim reduction and MCL flows - #4026
Closed
datagrokci[bot] wants to merge 1 commit into
Closed
Conversation
…tead of nullable name in dim reduction and MCL flows
Contributor
|
I don't like this check by dart and it's equality + currentTable might be null at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing dimensionality or MCL-clustering a table that has no name crashed with 'Not a table id: null', because the target view was looked up by the table's nullable name, which the shell rejects as an id before the add-view fallback can run.
The fix resolves views by DataFrame identity via a shared helper, and the dialog editors now return the actually selected dataframe even when its null name defeats the name-keyed choice input.
Diff: +20/-7 · 6 files
Verified: verification could not produce a definitive verdict — replay the recipe manually before merging
Full analysis: GROK-20814