CI-CD tests: fix the package Playwright specs failing in the nightly - #4019
Merged
Conversation
…ng it softStep re-threw any error whose message starts with "Test is skipped:". That is the suites' declared-skip idiom - the step records it and the spec's end-of-test realErrors filter drops it - so re-throwing escaped the step and Playwright failed the test. Two BiostructureViewer specs were reported red for a Mol*/WebGL skip that CI cannot satisfy. Every file using the idiom filters it at the end, so nothing else changes. Only a real TestSkipError, which test.skip() raises, is re-thrown now.
The spec drove the Formula widget through .add-new-column-dialog-cm-div. That class only belongs to the dialog: the widget-hosted editor labels its CM host -widget-cm-div, and it did so from 979ac73, which fixed the constructor to read its widget argument rather than the field it assigns later. Written before that, the spec kept the dialog class, the host could never be found, and all three info-panel edits failed - along with the save-reopen persistence check downstream of them, which read as a separate product bug. Accept either class. Verified on dev: the spec is green in 35.8s. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QN9RdbhoZ9sEoDNeM1EdCh
The Setup step waited 30s for .grok-prop-panel [name="pane-Details"] straight after addTableView, and step 2 waited for it again before setting grok.shell.o. The Context Panel renders the panes of the current object, and right after a table view opens that is the platform info object - Client/Server/Services/Plugins, no Details. Measured on dev, Details and Peptides both appear the moment shell.o is the AlignedSequence column, which is what step 2 does. Setup now checks only that the panel is open. Verified on dev, green in 17.0s. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QN9RdbhoZ9sEoDNeM1EdCh
LesiaPavlenko
force-pushed
the
opavlenko/cicd-triage-0831
branch
from
August 31, 2026 15:00
b4e0849 to
c29bbd6
Compare
Team decision: a test blocked by a known issue stays a plain failure and carries the ticket number, rather than being marked test.fail(). An xfail hides a real product bug behind a green suite, and Playwright and the CI report disagree about what it means. The three empty-input-row-viewers specs drop test.fail(). The ticket number stays in the assertion message, so the failure names it in the CI report without renaming the tests - a renamed test would leave its old name on the dashboard as a permanently red ghost row. Verified on dev, 3 failed, all on the balloon assertion, which is what CI already reports. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QN9RdbhoZ9sEoDNeM1EdCh
S1.4 polled 10s for the Bio:manageMonomerLibraries dialog. Measured on dev, the first dispatch takes 12.3s and a second one 0.2s - the first call pays the library load - and CI is slower than dev, which is why the step failed there every night while passing locally. Poll for 40s instead. Verified on dev, green in 1.1m. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QN9RdbhoZ9sEoDNeM1EdCh
LesiaPavlenko
force-pushed
the
opavlenko/cicd-triage-0831
branch
from
August 31, 2026 16:31
c29bbd6 to
21183af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five nightly package-Playwright failures, all measured and fixed on dev. Nightly Build-Deploy #1295–#1297 reported the same 22 package failures three nights running; these are the ones that turned out to be test bugs.
Every spec here was run against dev before and after. Merges cleanly onto current master.