Browse: ordering rules API surface and e2e suites - #4011
Open
alex-aprm wants to merge 1 commit into
Open
Conversation
Regenerated SettingsInterface for the new Settings.orderRules property that backs the Browse ordering rules. Adds three Playwright suites driving a live dev stack: - order-e2e.js: Browse tree ordering, per-space overrides, ordering by id - settings-e2e.js: the rules editor - layout, priorities, move/remove, typeahead, deferred apply, persistence - group-e2e.js: group / All-Users defaults, including a second session inheriting them Between them they caught several defects the analyzer cannot see, including a Dart 1.x `?.` chain that threw on the null path and a torn-off method used as a getter. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
alex-aprm
force-pushed
the
claude/spaces-ordering
branch
from
August 28, 2026 18:48
9cf76fe to
8eb8002
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the Bitbucket PR on
claude/spaces-ordering(reddata), which carries the feature itself.What's here
js-api/src/api/xamgle.api.g.ts— regenerated for the newSettings.orderRulesproperty backing the Browse ordering rules. Generated file; do not edit by hand.playwright-public/) driving a live dev stack:order-e2e.jsidsettings-e2e.jsgroup-e2e.js40 checks total, all passing against a local stack.
Why the suites are worth keeping
They caught defects static analysis cannot see, including a Dart 1.x
?.chain that threw on exactly the null path it was added for, and a torn-off method used as a getter (cell.valueStringwithout the call). Both compiled clean and failed only at runtime.Running them
Needs a dev stack on
DG_BASE(defaulthttp://localhost:61006) with anadmin/adminaccount:Notes
grok_api.g.tsandgrok_shared.api.g.tsare also regenerated locally, but that drift is unrelated to this change (committed Dart whose generated TS was stale) and is deliberately left out.playwright-public/already contained other untracked scratch files; only these three are added.🤖 Generated with Claude Code