Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/tutorials/src/tutorial.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export abstract class Tutorial extends DG.Widget {
grok.shell.windows.showBrowse = true;
}

async run(): Promise<void> {
async start(): Promise<void> {
this._addHeader();

const tutorials = this.track?.tutorials;
Expand Down Expand Up @@ -232,7 +232,7 @@ export abstract class Tutorial extends DG.Widget {
this.clearRoot();
tutorialNode.html('');
tutorialNode.append(nextTutorial.root);
nextTutorial.run();
nextTutorial.start();
}),
ui.button('Cancel', () => {
this.updateProgress(this.track);
Expand Down
1 change: 1 addition & 0 deletions packages/Tutorials/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## v.next

* Fixed the package build failing on `TS2416` — the u2 `Component` base introduced `run(fn)`, which every widget now inherits, so `Tutorial`'s own `run()` no longer matched; it is now `start()`
* GROK-20602: BREAKING regen — `grok api` codegen v2 for the Northwind demo schema: datetime fields are dayjs, typed expand/transaction surface, lazy db.ts clients
* Demo app: Added a Domain Databases demo (Data Access | Domain Databases) — ships the classic Northwind schema and data as a plugin-declared domain database (databases/northwind) and walks through browsing, security, audit history, and the JS API

Expand Down
2 changes: 1 addition & 1 deletion packages/Tutorials/src/tests/tutorial-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ category('Tutorials', () => {

test('Run a tutorial', async () => {
try {
await tutorial.run();
await tutorial.start();
} catch (e) {
expect(e instanceof Error ? e.message : e, 'Method "_run" not implemented.');
}
Expand Down
2 changes: 1 addition & 1 deletion packages/Tutorials/src/tutorial-runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class TutorialRunner {
$('#tutorial-child-node').html('');
$('#tutorial-child-node').append(t.root);
t.clearRoot();
await t.run();
await t.start();
}

async getCompleted(tutorials: Tutorial[]) {
Expand Down
Loading