[report 2297] GROK-20771: PowerPack: Route every current-user-group lookup through getCurrentUserGroup() and handle an unavailable group instead of dereferencing it - #3996
Merged
Conversation
…getCurrentUserGroup() and handle an unavailable group instead of dereferencing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the current user's group could not be retrieved,
grok.dapi.groups.findresolved to null and PowerPack dereferenced it as a non-nullable group in three places, throwing at startup and leaving the home page's dashboard widgets panel empty.All three sites now share the existing
getCurrentUserGroup()helper, which resolves null on a failed lookup (and does not cache the failure), so widgets without acanViewrestriction still render and permission-gated ones fail closed.Diff: +30/-12 · 4 files
Verified: reproduction recipe replayed on the patched build — the original error no longer fires
Full analysis: GROK-20771