[report 2304] GROK-20751: Peptides: Guard LogoSummaryTable.onPropertyChanged and render against a null dataFrame on a detached viewer - #3989
Merged
Conversation
…nder against a null dataFrame on a detached viewer
drizhina
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toggling columns in the Logo Summary Table's "Select columns..." dialog after the viewer was closed threw "NullError: method not found: 'filter' on null" on every toggle, because the detached viewer reacted to the property write and rendered from its now-null dataFrame.
The fix adds the same null-dataFrame early returns to LogoSummaryTable's onPropertyChanged and render that the package's sibling viewers (SARViewer, MonomerPosition, MostPotentResidues) already use, plus a regression test.
Diff: +16/-1 · 3 files
Verified: reproduction recipe replayed on the patched build — the original error no longer fires
Full analysis: GROK-20751