Skip to content

Fix spurious check for macro in MoPub ExchangeConnector #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsulmont wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix spurious check for macro in MoPub ExchangeConnector #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72cef3f
Fix spurious check for macro in adm
Apr 17, 2014
b4d3b12
always build before pushing
Apr 17, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions rtbkit/plugins/exchange/mopub_exchange_connector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,11 @@ getCreativeCompatibility(const Creative & creative,
}
tmp.clear();

// 4. Must have mopub.adm that includes MoPub's macro
// 4. Must have Ad Markup in HTML in mopub.adm
getAttr(result, pconf, "adm", crinfo->adm, includeReasons);
if (crinfo->adm.find("${AUCTION_PRICE:BF}") == string::npos)
if (crinfo->adm.empty())
result.setIncompatible
("creative[].providerConfig.mopub.adm ad markup must contain "
"encrypted win price macro ${AUCTION_PRICE:BF}",
("creative[].providerConfig.mopub.adm is null",
includeReasons);

// 5. Must have creative ID in mopub.crid
Expand Down