Skip nil quality monitor entries in ApplyPresets#5502
Merged
Conversation
Co-authored-by: Isaac
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
simonfaltum
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 099e05b
22 interesting tests: 15 SKIP, 7 KNOWN
Top 30 slowest tests (at least 2 minutes):
|
simonfaltum
requested review from
janniklasrose and
pietern
and removed request for
denik and
pietern
janniklasrose
approved these changes
Jun 10, 2026
denik
reviewed
Jun 10, 2026
| Resources: config.Resources{ | ||
| QualityMonitors: map[string]*resources.QualityMonitor{ | ||
| // Python-generated configs can contain null resource entries that | ||
| // bypass AllResourcesHaveValues, so ApplyPresets must skip them. |
Contributor
There was a problem hiding this comment.
Can we have an acceptance test for that? Python config that generates null entries.
I'd drop unit test, we know if q == nil works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Found during a full-repo review of the CLI. Every resource loop in
ApplyPresetsskips nil entries, except the quality monitors loop. Python-generated config can contain null resource entries that bypassAllResourcesHaveValues, so aquality_monitors.foo: nullentry crashes the CLI with a nil pointer dereference whentrigger_pause_statusis paused (the development mode default).Changes
Before, a nil entry in
quality_monitorspanicked inApplyPresets; now it is skipped like in every other resource loop. The fix adds the sameif q == nil { continue }guard the sibling loops inbundle/config/mutator/resourcemutator/apply_presets.goalready have.Test plan
TestApplyPresetsSkipsNilQualityMonitors, which panics without the fix and passes with itgo test ./bundle/config/mutator/resourcemutator./task fmt-q,./task lint-q,./task checksThis pull request and its description were written by Isaac.