Migrate DICOM anonymization FPE from FF3 to FF1#238
Open
erinaldidb wants to merge 2 commits into
Open
Conversation
…ving encryption. Update README and notebook documentation to reflect changes in fp_tweak handling. Replace ff3 with fastfpe in requirements and codebase. Clean up test imports and enhance test coverage for anonymization functionality.
dmoore247
self-requested a review
July 10, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the DICOM anonymization format-preserving encryption implementation away from
ff3/FF3-1 and ontofastfpe/FF1, updates the related documentation and demo notebook guidance, and expands anonymization test coverage around deterministic encryption, tweak handling, and metadata behavior.Why this is required
NIST's February 2025 Draft 2 update to SP 800-38G Rev. 1 entirely withdraws FF3 and FF3-1 from the NIST standard due to published vulnerabilities. Because Pixels uses format-preserving encryption for DICOM de-identification, continuing to depend on FF3/FF3-1 would leave the accelerator aligned with a withdrawn construction. Migrating to FF1 keeps the anonymization workflow on the NIST-retained FPE mode.
Changes
ff3dependency withfastfpe.fp_tweakbehavior.Validation
This PR was created with GitHub MCP.