Integrate NIfTI overlay support#237
Open
erinaldidb wants to merge 15 commits into
Open
Conversation
- Introduced optional NIfTI segmentation table configuration in `app.yml` and `app-config.yml`. - Implemented new API endpoints for fetching NIfTI overlay metadata and files. - Updated handlers and query builders to support NIfTI overlay functionality. - Enhanced documentation in the deployment notebook regarding NIfTI integration.
- Updated documentation to clarify feature gating based on pixels_table and NIFTI_SEGMENTATION_TABLE. - Refactored table resolution logic to derive NIfTI table from pixels_table cookie or environment variable. - Improved error handling for cases when no valid table configuration is available.
…ns/pixels into feature/nifti_integration
…ricks-industry-solutions/pixels into feature/nifti_integration
…ns/pixels into feature/nifti_integration
dmoore247
requested changes
Jul 10, 2026
dmoore247
left a comment
Collaborator
There was a problem hiding this comment.
Please confirm PR has been a full install tested, end to end, starting from nothing.
Big question what happens if feature is on (by default) and NIFTI_SEGMENTATION table is not loaded. Possible 404 error.
| WHERE study_instance_uid = %(study)s | ||
| AND series_instance_uid = %(series)s | ||
| AND (status IS NULL OR status <> 'archived') | ||
| ORDER BY version DESC NULLS LAST, created_at DESC |
Collaborator
There was a problem hiding this comment.
No limit to # rows returned. The client has a limit of 25?
| WHERE study_instance_uid = %(study)s | ||
| AND series_instance_uid = %(series)s | ||
| AND id = %(id)s | ||
| LIMIT 1 |
Collaborator
There was a problem hiding this comment.
No order by so it is indeterministic as to which one would be returned.
| valueFrom: "sql_warehouse" | ||
| - name: "DATABRICKS_PIXELS_TABLE" | ||
| value: "{PIXELS_TABLE}" | ||
| - name: "NIFTI_SEGMENTATION_TABLE" |
Collaborator
There was a problem hiding this comment.
On by default, chance that upon fresh deploy, code will hit 404 until is populated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a key item on the roadmap by introducing native NIfTI (Neuroimaging Informatics Technology Initiative) integration into the Pixels solution accelerator. Previously focused on DICOM imaging datasets, this expansion allows the framework to scale, ingest, and process NIfTI data formats directly within the Databricks Data Intelligence Platform.
Key Changes
NIfTI Ingestion Pipeline: Extends Pixels' parallel processing framework to parse, read, and ingest NIfTI format imaging data (.nii / .nii.gz).
Metadata & Property Extraction: Enables seamless extraction of NIfTI-specific headers, dimensional properties, and coordinate information to map them into Delta Lake tables for fast, downstream Spark SQL metadata analytics.
Pipeline Enhancements: Introduces underlying utilities to cleanly handle, extract, and convert neuroimaging file streams alongside the existing DICOM processing architecture.
Example notebook available here: notebooks/nifti/IRCAD Sample Data Loader.ipynb
Sample file used: ircad_e01_package.tar.gz