Repository navigation
Removing snapshot to release Wrangler 4.10.3 with CDAP 6.10.8 - #1060
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request prepares Wrangler for the 4.10.3 release by removing the -SNAPSHOT suffix from the project version across several pom.xml files. However, in the root pom.xml, the cdap.version property was incorrectly changed to 4.10.3 instead of 6.10.8. The review feedback correctly identifies this mistake and suggests updating the CDAP version to 6.10.8.
| <bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version> | ||
| <bouncycastle.version>1.56</bouncycastle.version> | ||
| <cdap.version>6.10.8-SNAPSHOT</cdap.version> | ||
| <cdap.version>4.10.3</cdap.version> |
There was a problem hiding this comment.
The cdap.version property was incorrectly changed to 4.10.3 instead of 6.10.8. Based on the pull request title "Removing snapshot to release Wrangler 4.10.3 with CDAP 6.10.8", the CDAP version should be updated to 6.10.8 (removing the -SNAPSHOT suffix).
Suggested change
| <cdap.version>4.10.3</cdap.version> | |
| <cdap.version>6.10.8</cdap.version> |
sahusanket
force-pushed
the
remove_snap_for_release_6108
branch
from
September 29, 2026 08:26
ca0bf66 to
fcec72f
Compare
vsethi09
approved these changes
Sep 29, 2026
| <bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version> | ||
| <bouncycastle.version>1.56</bouncycastle.version> | ||
| <cdap.version>6.10.8-SNAPSHOT</cdap.version> | ||
| <cdap.version>4.10.3</cdap.version> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.