Skip to content

Removing snapshot to release Wrangler 4.10.3 with CDAP 6.10.8 - #1060

Merged
vsethi09 merged 2 commits into
release/4.10from
remove_snap_for_release_6108
Sep 29, 2026
Merged

vsethi09 merged 2 commits into
release/4.10from
remove_snap_for_release_6108

Conversation

@sahusanket

Copy link
Copy Markdown
Contributor

No description provided.

@sahusanket sahusanket self-assigned this Sep 29, 2026
@sahusanket sahusanket added the build Triggers unit test build label Sep 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares Wrangler for the 4.10.3 release by removing the -SNAPSHOT suffix from the project version across several pom.xml files. However, in the root pom.xml, the cdap.version property was incorrectly changed to 4.10.3 instead of 6.10.8. The review feedback correctly identifies this mistake and suggests updating the CDAP version to 6.10.8.

Comment thread pom.xml Outdated
<bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version>
<bouncycastle.version>1.56</bouncycastle.version>
<cdap.version>6.10.8-SNAPSHOT</cdap.version>
<cdap.version>4.10.3</cdap.version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The cdap.version property was incorrectly changed to 4.10.3 instead of 6.10.8. Based on the pull request title "Removing snapshot to release Wrangler 4.10.3 with CDAP 6.10.8", the CDAP version should be updated to 6.10.8 (removing the -SNAPSHOT suffix).

Suggested change
<cdap.version>4.10.3</cdap.version>
<cdap.version>6.10.8</cdap.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

@sahusanket
sahusanket force-pushed the remove_snap_for_release_6108 branch from ca0bf66 to fcec72f Compare September 29, 2026 08:26
Comment thread pom.xml Outdated
<bigquery.connector.hadoop2.version>0.10.2-hadoop2</bigquery.connector.hadoop2.version>
<bouncycastle.version>1.56</bouncycastle.version>
<cdap.version>6.10.8-SNAPSHOT</cdap.version>
<cdap.version>4.10.3</cdap.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this

@vsethi09
vsethi09 merged commit 17b7723 into release/4.10 Sep 29, 2026
2 of 6 checks passed
@vsethi09
vsethi09 deleted the remove_snap_for_release_6108 branch September 29, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Triggers unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants